Month: May 2011

NGS hotfixes for 2011-05-27

A small set of fixes to finish the week. The next release after this is currently scheduled for Wednesday. Thanks for sticking with us through the NGS launch week! Please keep the bug reports coming in, no matter how insignificant you think the issue may be, your reporting has been tremendously helpful. The Git tag for this version is ocharles/v-2011-05-27-ngs-hotfixes – the official tag will be out late Monday (I don’t have a key to sign the tag with).

One note about the Sound Juicer/RhythmBox issues – this is actually a problem with programs being compiled against libmusicbrainz2, instead of libmusicbrainz3 and there’s nothing we can do about these problems. If you are experiencing problems we recommend you compile from source, or wait/pester your distribution to update their packages.

Bug

  • [MBS-2249] – Sound Juicer no longer works with NGS
  • [MBS-2274] – Sort names being returned incorrectly for multiple artist credits on /ws/1
  • [MBS-2295] – UX: Add Missing Entities loses your selections for artists if you forget to select (or add new artist sort-name for) one of them
  • [MBS-2296] – FixTrackLength script (aka modbot automatically setting track lengths) checks are wrong
  • [MBS-2328] – When seed release editor with recording ids for tracks the Release Editor associates them with the wrong tracks unless recording ids have been allocated for every track
  • [MBS-2332] – Error trying to edit tracklist of a release to remove excesive quoting
  • [MBS-2350] – Subscribe link doesn’t work (missing id)

Improvement

  • [MBS-2353] – Update javascript code for relationships so Wikipedia URL are recognized automatically for works

NGS hot fixes for 2011-05-26

Another day, another bunch of bug fixes! I do wonder sometimes, “how could we have got so much, so wrong?” but we’re making some really good progress. Here’s what you should find fixed now:

Bug

  • [MBS-1169] – Musicbrainz NGS Server is missing a hell of a lot of HTML sanitization. (HTML/script injections galore…)
  • [MBS-1814] – Add release from disc ID adds disc ID to every disc
  • [MBS-1956] – Adding translated tracklistings is impossible
  • [MBS-1965] – You have no collections!
  • [MBS-1993] – External links not appearing on label page
  • [MBS-2023] – CD Baby not showing up in external links
  • [MBS-2027] – Amazon cover art does not display for URL added post NGS
  • [MBS-2068] – Specify that "found ### edits" in edit listing is an estimation
  • [MBS-2119] – Punctuation not shown when editing medium
  • [MBS-2209] – Tracklist preview shows empty "disc 0"
  • [MBS-2210] – Collapsed discs cause Add Disc page to appear off top of page
  • [MBS-2277] – Basic editor more likely to lose or misapply associations between tracklists and recordings than advanced editor
  • [MBS-2281] – [ws/1] release-group request change in behavior
  • [MBS-2300] – An "edit medium" edit got stuck and can’t be approved
  • [MBS-2304] – Clicking on "Artist as credited on this track" deletes the text
  • [MBS-2308] – Displaying {additional:addionally} and so on next to relationships in all relationship pages.
  • [MBS-2309] – Invalid WS request causes crash
  • [MBS-2311] – Release editor: "An artist is required on track n" when seeding parameters to release editor
  • [MBS-2316] – Broken link in "edits for your subscription" email
  • [MBS-2319] – Cannot merge multiple recordings that have a common ISRC

Improvement

  • [MBS-1978] – "External Links" display in the sidebar doesn’t work as intended

The Git tag for this version is v-2011-05-26-ngs-hotfixes.

NGS hot fixes for 2011-05-25

Thanks for sticking with us through that brief bit of downtime for editors – here’s what we got fixed today! Of interest especially is the improved support for relationship edits in artist history. Hopefully tomorrow we will clean up the subscription system a bit more, so you can get back to voting! This version is v-2011-05-25-ngs-hotfixes in Git.

Bug

  • [MBS-1945] – Relationships edits dont appear in artist history
  • [MBS-1990] – Can’t import/add certain freedb/discid releases: "An artist is required on track x" for all tracks
  • [MBS-2057] – [ws/1] track request is missing tracknumbers in release-list after ngs migration
  • [MBS-2102] – Adding a new release/tracklist that shares recordings changes existing release tracklist
  • [MBS-2129] – Edits submitted when no changes made
  • [MBS-2130] – Edit medium (to correct separate bug) didn’t remove intended tracks
  • [MBS-2135] – Send subscriptions emails at the normal time
  • [MBS-2140] – Recordings automatically changed when editing release with CD+DVD with same track names
  • [MBS-2141] – Search indices not updating every 6 hours?
  • [MBS-2177] – All recordings are forgotten if you go back to Tracklist from Recordings
  • [MBS-2198] – Using Artist Credit with no join phrase results in a server error
  • [MBS-2219] – Internal Server error trying to edit artist credit and track title in advanced error for mashup
  • [MBS-2263] – Link in a URL’s title is incorrect
  • [MBS-2270] – Internal Server Error for invalid timezone
  • [MBS-2271] – broken link on ‘Edit Relationship’ page
  • [MBS-2272] – Cannot display some edit relationship edits
  • [MBS-2285] – Internal Server Error adding/removing anything from collection

Improvement

  • [MBS-1706] – Indicate date is Y/M/D in the RE
  • [MBS-1946] – Readd old relationships phrases in database in addition to new short ones

NGS hot fixes for 2011-05-24

More bug fixes for the NGS release, keeping up with our promise of daily hot fixes! A lot of work today, but a good whack of it is still in review, so that will be coming tomorrow. Here’s what you should see on the servers:

Bug

  • [MBS-1896] – Editing Artist/Label Name capitalisation results with "Possible Duplicate Artists" warning
  • [MBS-2106] – Unable to add new release using FreeDB import: process freezes when clicking "Add disc" radio button
  • [MBS-2163] – Internal Server Error attempting to assign a title to a medium
  • [MBS-2171] – Expand Disc does not result in the correct action
  • [MBS-2179] – Remove disc in release editor tracklist pane does nothing
  • [MBS-2181] – Internal Server Error when submitting edit to remove and add disc
  • [MBS-2203] – Internal server error when importing VA release from freedb via freedb search > import
  • [MBS-2206] – Advanced editor: Can’t add tracks to new mediums
  • [MBS-2254] – Viewing the page for a tag which is only present on works gives a internal server error for template
  • [MBS-2261] – Release group is listed twice on an artist page
  • [MBS-2267] – Number of mediums doubled on ‘Disc IDs’ page
  • [MBS-2279] – Medium heading displayed twice in list of disc IDs
  • [MBS-2280] – [ws/1] release-group search returns invalid xml
  • [MBS-2284] – Disc IDs shown with duplicate CD1/CD2 headings

Improvement

  • [MBS-1717] – Allow selecting the release group of a release in the release editor

Please feel free to make use of these, if you want to do more testing, remember our test servers are also up to date! The tag for this version in Git is v-2011-05-24-ngs-hotfixes

Attention CD lookup software authors!

We’re getting a number of reports from Rhythmbox, Sound Juicer and other applications that their CD lookup is no longer working. We currently have no open bugs that tell us what is wrong, so we can’t fix anything.

We believe that we are outputting correct XML for CD lookups, thus there isn’t anything for us to fix. We are, however, outputting more matches for CDs, since multiple releases for a single CD can be returned. But, this is nothing new — clients should’ve supported this even before NGS.

We need the authors of programs that are broken to tell us what broke their stuff. Then we can determine if we need to fix something, the authors need to fix something or if we can come up with some sort of compromise. We’ve been talking about NGS for two years and these application authors never bothered to test their applications with our new stuff.

End users who are upset at CD Lookups failing: Please go complain to your software authors to resolve these issues or file bug reports with us if the trouble is in MusicBrainz.

NOTE: These applications are not failing because of User-Agent blocking — we haven’t actually started doing that.

NGS hot fixes for 2011-05-23

We’ve just finished rolling out todays bug fixes to last weeks NGS release. We’re going to be carrying on daily releases in this fashion for at least the next week.

Bug

  • [MBS-379] – Release search shows incorrect # tracks.
  • [MBS-1930] – Release view: Inconsistent display of fields in sidebar between tabs
  • [MBS-2052] – Cannot add new releases- "A track name is required on track <N>" for all tracks when submitting with discId/toc
  • [MBS-2069] – Adding a duplicate relationship gives an internal server error
  • [MBS-2072] – Release added against incorrect existing tracklist, even after track removed in release editor
  • [MBS-2099] – Add PUIDs edits should not appear in artist editing history
  • [MBS-2110] – Internal Server Error adding Jaikoz-sourced release on Edit Notes page of release editor
  • [MBS-2125] – Creating a release based on another one uses wrong track list
  • [MBS-2128] – Internal server error when searching for edits
  • [MBS-2145] – Duplicated ISRCs allowed on recording
  • [MBS-2148] – Internal Server Error while creating RG <-> RG AR
  • [MBS-2152] – Possible to add releases with no mediums
  • [MBS-2156] – Server error: Splitting a collaboration into credits
  • [MBS-2182] – Cannot display country/gender of artists in indexed release search results
  • [MBS-2208] – Database Statistics shows percentage over 100%
  • [MBS-2217] – Internal Server Error viewing my edits page
  • [MBS-2218] – Internal Server Error performing /ws/2 PUID lookup
  • [MBS-2222] – Errors when submitting relationship without selecting a type
  • [MBS-2251] – Webservice fails if query includes "&"

Improvement

  • [MBS-1971] – Guess medium position from the release title when merging releases
  • [MBS-2094] – Missing space in "~Release"

The tag for this version in Git is ‘v-20110523-ngs-hotfixes’

First NGS Bug Fix Release Now Out

Our first set of bug fixes have now been deployed on our production servers! Please keep the bug reports coming in, we’re aiming to do almost daily releases until we really get things stable. Here are the bugs that are now fixed:

Bug

  • [MBS-1660] – “To be cancelled” edits aren’t highlighted
  • [MBS-1665] – “Artist as credited” gray default must be manually set
  • [MBS-1776] – Seeding releases no longer picking up tracks on ngs.musicbrainz.org
  • [MBS-1888] – Change direction shown for relationships where changing the direction is not possible
  • [MBS-1897] – 500 error in release editor
  • [MBS-1898] – Changing artist {credit} for release and tracks in VA conflicts
  • [MBS-1902] – Internal Server Error trying to edit a Release<->URL relationship
  • [MBS-1912] – Weirdness after editing release labels
  • [MBS-1913] – “Attribute (params) does not pass the type constraint because: Validation failed for ‘HashRef’ with value undef”
  • [MBS-1931] – Beethoven’s Relationships timeout
  • [MBS-1952] – Simultaneous Release edits impossible
  • [MBS-1954] – Medium edit page shows tracklist when it hasn’t been changed
  • [MBS-1959] – Internal server error when trying to relate a recording to a work
  • [MBS-1962] – Cannot cancel edit
  • [MBS-1963] – Release in a remove release label edit doesn’t display
  • [MBS-1967] – Internal Server Error in relate to recordings
  • [MBS-1977] – ModBot complains more
  • [MBS-1980] – ISE when adding standalone recordings for artists not in the DB
  • [MBS-1996] – Setting track durations from TOC returns back to same page
  • [MBS-2002] – “Internal Server Error” when attempting to add release to existing release group
  • [MBS-2003] – Error entering a various artists edit
  • [MBS-2004] – Internal Server Error attaching Discogs URL
  • [MBS-2006] – Internal Server Error submitting add release label edit
  • [MBS-2019] – Release editor > Advanced tracklist mode > Can’t change artist credits of tracks of a release with 5 mediums
  • [MBS-2024] – Voting twice gives odd results
  • [MBS-2089] – Error displaying release label edit
  • [MBS-2090] – Merge artists doesn’t show whether the keep artist credits box is ticked
  • [MBS-2091] – All relationship IDs in the URL cleanup JS are incorrect
  • [MBS-2100] – Removing an {artist} alias is an autoedit for autoeditors
  • [MBS-2105] – Merged artist not being redirected to target artist